Shadow options for DesignableTextView, DesignableTextField, and DesignableImageView#316
Open
ryanlietzenmayer wants to merge 5 commits intoMengTo:masterfrom
Open
Shadow options for DesignableTextView, DesignableTextField, and DesignableImageView#316ryanlietzenmayer wants to merge 5 commits intoMengTo:masterfrom
ryanlietzenmayer wants to merge 5 commits intoMengTo:masterfrom
Conversation
DesignableView and DesignableButton both support drop shadows as IBInspectable and available in Interface Builder.
DesignableView and DesignableButton both support drop shadows as IBInspectable and available in Interface Builder.
DesignableView and DesignableButton both support drop shadows as IBInspectable and available in Interface Builder.
Shadow options for DesignableTextField.swift
Shadow options for DesignableTextView.swift
Author
|
The DesignableTextField and DesignableImageView changes are working, but I'm having trouble showing shadows with the DesignableTextView. |
Author
|
With this change, DesignableTextView will only show shadows if I don't know where it's getting set to true. |
Author
Adding clipsToBounds here makes shadows show in-app, but prevents the Clips to Bounds checkbox in Interface Builder from cutting off shadows like it does by default. Definitely not a graceful solution. Note, setting |
cs4alhaider
approved these changes
Sep 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These options were present for DesignableView and DesignableButton, but not DesignableTextView, DesignableTextField, and DesignableImageView. I do not know if this is an intentional choice, but this is an inconsistency.
I updated DesignableTextView, DesignableTextField, and DesignableImageView to match shadow options on existing views.